Allow connectionParams to be provided as part of wsOptions for replication-graphql #6741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
A new feature: ability to provide a connectionParams function as part of wsOptions
Describe the problem you have without this PR
When opening a websocket for a graphql subscription, we need to provide authorization headers to authenticate. Currently, this works fine on the initial connection, but if the original token provided expires and graphql-ws needs to reconnect, there is currently no way to update the headers. Calling .setHeaders on the replicationState does not change the headers rxdb provides to graphql-ws when reconnecting.
To fix this issue, we need to be able to provide a connectionParams function which will ensure that a fresh access token can always be sent as part of the connection headers.