Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RxDB version details in MongoDB handshake #6722

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

alexbevi
Copy link
Contributor

@alexbevi alexbevi commented Jan 3, 2025

The PR incorporates MongoDB's wrapping client library specification for the connection handshake to allow library details to be included in the metadata written to mongos or mongod logs.

For example, this change would allow server-side logs such as the following:

{"t":{"$date":"2024-01-27T23:10:40.108Z"},"s":"I","c":"NETWORK","id":51800,"ctx":"conn16235","msg":"client metadata","attr":{"remote":"127.0.0.1:1094","client":"conn16235","doc":{"driver":{"name":"nodejs|RxDB","version":"6.12.0|16.0.0"},"platform":"Node.js v18.18.2, LE","os":{"name":"linux","architecture":"x64","version":"5.15.133+","type":"Linux"}}}}

For anyone hosting clusters with connections coming from different applications this can help differentiate connections and facilitate log analysis.

TODO

  • Add proper version RxDB version tracking (I'm not sure where to pull this from)

@alexbevi
Copy link
Contributor Author

alexbevi commented Jan 3, 2025

This would be the same type of change as meteor/meteor#13222

@pubkey pubkey merged commit c42c889 into pubkey:master Jan 4, 2025
19 of 20 checks passed
pubkey added a commit that referenced this pull request Jan 4, 2025
@alexbevi alexbevi deleted the patch-1 branch January 4, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants