Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for js console causing browser to become unresponsive #715

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

kgns
Copy link
Contributor

@kgns kgns commented Nov 2, 2017

think it's obvious what the problem was :)
problem 1 on #706

@DaneEveritt
Copy link
Member

Doesn't this introduce the possibility of the console sitting at the top for awhile if loading a large enough file? Should we be pushing to the bottom every X lines rather than every line?

I honestly can't remember how many I load at once here, but I'm guessing its not that many so this probably isn't a concern.

@schrej
Copy link
Member

schrej commented Nov 2, 2017

Well that's better than lagging the whole website. Also adding lines outside of the viewport of the terminal is probably faster than when they are shown all the time by scrolling down

@kgns
Copy link
Contributor Author

kgns commented Nov 2, 2017

I have a few busy servers with a lot of lines of console log, and when tested with this change, i did not ever see the console at the top. Thing is, i don't think lines are rendered one by one or by a buffer size. Initial logs are rendered after every line is pushed and console is scrolled to bottom. So just having a single scrollToBottom at the end will be the best for performance, speed, and also will never cause the console to be stuck at the top

@DaneEveritt DaneEveritt merged commit f5feb28 into pterodactyl:develop Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants