Only auto-scroll terminal on new output when at the bottom #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrej
changed the title
schrej
changed the title
|
There are some issues with Chrome currently, I would put this on hold (but keep the PR open) until this is resolved, then i will update this. |
set new scrollBottomOffset to 5 to hopefully resolve issues with chrome
|
With the latest addition (d844c41) all Chrome issues on Ubuntu have been resolved. Works flawless. |
|
Perfect. In my opinion it's ready to merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates jquery.terminal to version 0.11.23 to enable new (requested) features.
The server terminal now only automatically scrolls when it is scrolled all the way down.
If there is new output that is not visible a small notification appears at the bottom right. A click on it will scroll all the way down.
fixes #153