Deno overhaul #70
Merged
Deno overhaul #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove fileText property from psychDSFileDeno class - Remove JSON-LD parsing and expansion from _readFileTree function - Remove context handling for dataset_description.json - Simplify file reading process in _readFileTree This change reverts the earlier modification that added fileText and moved JSON-LD parsing to the readFileTree stage. It streamlines the file reading process and removes browser-specific accommodations.
…rom readFileTree - Remove fileText property and JSON-LD parsing from psychDSFileDeno class - Simplify _readFileTree function by removing JSON-LD expansion and context handling - Move JSON-LD expansion to getExpandedSidecar method in context.ts - Update applyRules.ts to work with the new structure, removing fileText references - Adjust psychds.ts to handle JSON-LD processing changes and error handling This refactor simplifies the file reading process, moves JSON-LD handling to a more appropriate location, and improves overall code organization and maintainability.
- Remove fileText property from psychDSFile interface - Add expanded property to psychDSFile for storing expanded JSON-LD - Update Context interface to include validColumns and suggestedColumns - Add metadataProvenance to Context for tracking metadata sources These changes align the type definitions with the recent refactoring of file reading and JSON-LD processing, improving type safety and clarity throughout the codebase.
- Refactor applyRules.test.ts to use a setupTest helper function - Update test cases to work with the new file reading and JSON-LD processing flow - Adjust context.test.ts to handle the new psychDSContext structure - Update assertions to check for expanded JSON-LD properties - Remove fileText references and update to use new expanded property These changes align the tests with the recent refactoring of file reading and JSON-LD processing, ensuring continued test coverage and validity.
Refactor file reading and JSON-LD processing
…verhaul--components--your-package-name chore(deno_overhaul): release 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.