Remove numeric underscore normalization #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsol
force-pushed
the
remove_num_underscores
branch
from
0be016e to
2a30be8
Compare
Pull Request Test Coverage Report for Build 889
💛 - Coveralls |
4 similar comments
Pull Request Test Coverage Report for Build 889
💛 - Coveralls |
Pull Request Test Coverage Report for Build 889
💛 - Coveralls |
Pull Request Test Coverage Report for Build 889
💛 - Coveralls |
Pull Request Test Coverage Report for Build 889
💛 - Coveralls |
Pull Request Test Coverage Report for Build 909
💛 - Coveralls |
JelleZijlstra
requested changes
Feb 6, 2019
README.md
Outdated
| the `-N` or `--skip-numeric-underscore-normalization` command line option | ||
| makes *Black* preserve underscores in numeric literals. | ||
| styled as `2L` instead of `2l` to avoid confusion between `l` and `1`. | ||
| In Python 3.6 and later, *Black* preserves underscores in numeric literals. |
There was a problem hiding this comment.
Maybe add "unchanged"? Otherwise, I'm not sure it's worth mentioning something Black doesn't change.
There was a problem hiding this comment.
Hm, fair enough. I'll just remove this sentence.
tests/data/fmtonoff.py
Outdated
| @@ -4,13 +4,13 @@ | |||
|
|
|||
| from third_party import X, Y, Z | |||
|
|
|||
| from library import some_connection, \ | |||
| some_decorator | |||
| from library import some_connection, some_decorator | |||
There was a problem hiding this comment.
This looks like you accidentally blackened the whole file.
tests/data/function.py
Outdated
| from library import some_connection, \ | ||
| some_decorator | ||
| f'trigger 3.6 mode' | ||
| from library import some_connection, some_decorator |
JelleZijlstra
approved these changes
Feb 6, 2019
|
Hi, when this will be released? |
enrico-usai
added a commit
to enrico-usai/aws-parallelcluster
that referenced
this pull request
Mar 15, 2019
The option used to preserve underscores in numeric literals has been removed from Black. Black no longer normalizes numeric literals to include _ separators. See: psf/black#549 psf/black#696 Signed-off-by: Enrico Usai <[email protected]>
enrico-usai
added a commit
to aws/aws-parallelcluster
that referenced
this pull request
Mar 15, 2019
The option used to preserve underscores in numeric literals has been removed from Black. Black no longer normalizes numeric literals to include _ separators. See: psf/black#549 psf/black#696 Signed-off-by: Enrico Usai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549.