Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Geth Fork #5865

Merged
merged 75 commits into from
Jun 1, 2020
Merged

Update Geth Fork #5865

merged 75 commits into from
Jun 1, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented May 15, 2020 •
edited
Loading

  • Update the geth fork commit we reference to so that we are up to date with upstream.
  • Fix API changes to discovery related methods
  • Regenerate bindings as a few types are no longer in abigen in upstream
    go-ethereum.
  • Disable nilness analyzer for nogo, as it doesn't work well with go-ethereum.
  • Refactored bazel-go-ethereum to make its deps loadable to downstream users.

@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #5865 into master will decrease coverage by 0.01%.
The diff coverage is 68.57%.

@@            Coverage Diff             @@
##           master    #5865      +/-   ##
==========================================
- Coverage   59.53%   59.51%   -0.02%     
==========================================
  Files         320      320              
  Lines       27110    27023      -87     
==========================================
- Hits        16140    16083      -57     
+ Misses       8776     8749      -27     
+ Partials     2194     2191       -3

@nisdas nisdas marked this pull request as ready for review May 21, 2020 06:13
@nisdas nisdas requested a review from a team as a code owner May 21, 2020 06:13
@nisdas nisdas requested a review from prestonvanloon as a code owner May 31, 2020 08:03
rauljordan
rauljordan previously approved these changes Jun 1, 2020
View reviewed changes
@rauljordan rauljordan mentioned this pull request Jun 1, 2020
Closed
prestonvanloon
prestonvanloon requested changes Jun 1, 2020
View reviewed changes
BUILD.bazel Outdated Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit afbe494 into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the updateGeth branch June 1, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@rauljordan rauljordan rauljordan left review comments

@farazdagi farazdagi Awaiting requested review from farazdagi

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @rauljordan @prestonvanloon