Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fork Choice to Use Balance #1564

Merged
merged 24 commits into from
Feb 13, 2019
Merged

Update Fork Choice to Use Balance #1564

merged 24 commits into from
Feb 13, 2019

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 12, 2019

This is part of #1541. In v0.02, spec uses fork choice uses validator balance scoring

Key changes:

  • Implement get latest attestation
  • Implement get latest attestation target
  • Update get vote count
  • Implement new tests and update existing tests

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #1564 into master will decrease coverage by 0.58%.
The diff coverage is 89.47%.

@@            Coverage Diff            @@
##           master   #1564      +/-   ##
=========================================
- Coverage   72.08%   71.5%   -0.59%     
=========================================
  Files          99      98       -1     
  Lines        6763    6562     -201     
=========================================
- Hits         4875    4692     -183     
+ Misses       1464    1459       -5     
+ Partials      424     411      -13

@terencechain terencechain merged commit 59e5e59 into master Feb 13, 2019
@nisdas nisdas deleted the update-fork-choice-571 branch April 20, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants