Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Synchronize android & iOS same props to easily config #6

Merged
merged 6 commits into from
Mar 27, 2018
Merged

-Synchronize android & iOS same props to easily config #6

merged 6 commits into from
Mar 27, 2018

Conversation

congnguyen91
Copy link
Contributor

  1. Update read Me
  2. Fix config for Android
    Before:
  • cancelable: "true" => cancelable: true
  • targetRadius: '14' => targetRadius: 14

@congnguyen91
Copy link
Contributor Author

  • Hey @prscX,
    I also update commit tag on pod file for iOS.
    MaterialShowcase 0.51 (native) still haven't included my objc flag for swift :)

@prscX
Copy link
Owner

prscX commented Mar 27, 2018

@congnguyen91: WOW 😮, you are awesome. Would like to appreciate for the thought and effort behind this PR.

I have merged the same and by EOD will push the release.

Thanks
Pranav

@prscX prscX merged commit dc242cb into prscX:master Mar 27, 2018
@prscX
Copy link
Owner

prscX commented Mar 28, 2018

Many Thanks @congnguyen91 for the effort and PR. I have pushed the release, now you will be able to consume these changes from V0.0.4 and onwards.

Thanks
Pranav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@congnguyen91 @prscX