feat(android): 🌟 add support for React Native 0.73 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,13 +1,11 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="com.proyecto26.inappbrowser"> | |||
There was a problem hiding this comment.
This does remove backwards compatability
There was a problem hiding this comment.
@peterlazar1993 please revert this 🙏
jdnichollsc
reviewed
Nov 1, 2023
| @@ -27,6 +27,7 @@ def DEFAULT_MIN_SDK_VERSION = 16 | |||
| def DEFAULT_TARGET_SDK_VERSION = 31 | |||
|
|
|||
| android { | |||
| namespace = "com.proyecto26.inappbrowser" | |||
There was a problem hiding this comment.
can you verify the gradle plugin version to have backward compatability please? e.g:
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
if (agpVersion >= 7) {
namespace 'com.proyecto26.inappbrowser'
}There was a problem hiding this comment.
More examples here:
- https://github.com/th3rdwave/react-native-safe-area-context/blob/main/android/build.gradle#L43
- https://github.com/react-native-netinfo/react-native-netinfo/blob/master/android/build.gradle#L34
- https://github.com/invertase/react-native-firebase/blob/main/packages/app/android/build.gradle#L62
|
@peterlazar1993 thanks for your contribution, I added some comments, please let me know and thanks for your help! <3 |
|
I want to publish a new version of this lib after fixing this issue 🙏 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Starting from React Native v0.73 , all libraries will need to be updated with namespace due to the upgrade to AGP 8
react-native-community/discussions-and-proposals#671
Test Plan
I tested the changes on RN 0.71.11 and everything works!
Sorry I did not use the default template. I felt that the default template does not apply to this, I'll follow the template if required!