Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created asmdef for sample + moved the sample to unity recommended directory (Samples~ instead of sample) #205

Merged
merged 11 commits into from
Jan 9, 2022

Conversation

kbobnis
Copy link
Contributor

@kbobnis kbobnis commented Jan 7, 2022

  1. Before this change, when importing package, the package was fetching the sample directory as part of the package.
    Moving sample to special named directory Samples~ (https://docs.unity3d.com/Manual/cus-samples.html) will force the unity package manager UPM to skip this directory when importing package. An option to download sample is still visible in the UPM under RestClient package.
  2. The sample uses RestClient package, therefore another asmdef was created for sample with dependency to RestClient.

Known problems:

  1. Only when optionally downloading the sample: The sample can't find method: CleanDefaultHandlers - I don't know why
    Assets\Samples\RestClient for Unity\2.6.2\Sample\MainScript.cs(48,15): error CS0117: 'RestClient' does not contain a definition for 'CleanDefaultHeaders'

@kbobnis kbobnis marked this pull request as ready for review January 7, 2022 11:36
@kbobnis kbobnis mentioned this pull request Jan 7, 2022
@kbobnis
Copy link
Contributor Author

kbobnis commented Jan 7, 2022

I have created an empty project with only this package imported to showcase this error: https://github.com/kbobnis/proyecto26-restclient-imported-with-sample

@jdnichollsc
Copy link
Member

Oh about the error, that function was renamed to ClearDefaultHeaders 😅

@kbobnis Let me update that and thanks for your contribution mate! <3

@jdnichollsc jdnichollsc merged commit 766eba4 into proyecto26:develop Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants