ci: Publish RxAndroidBle fork to Artifactory (DROID-1123) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonrohan
reviewed
Jul 30, 2021
gradle.properties
Outdated
| @@ -19,3 +19,6 @@ POM_DEVELOPER_NAME2=Paweł Urban | |||
|
|
|||
| android.useAndroidX=true | |||
| android.enableJetifier=false | |||
|
|
|||
| artifactoryUsername=android-gradle | |||
| artifactoryPassword=TQy+dwFh6vdHt | |||
There was a problem hiding this comment.
Should these be env variables from 1Password?
There was a problem hiding this comment.
They should be in 1password, aren't they?
There was a problem hiding this comment.
I meant should the script itself fetch it from the developers/ci machines env var rather than have it plaintext in the repo
And have the names be like
proxyAndroidArtifcatoryUsername
proxyAndroidArtifcatoryPassword
There was a problem hiding this comment.
This is not running on any ci, only local machine as it is not updated very often. We should however do that for the android repo, not just for the artifactory credentials but others as well.
There was a problem hiding this comment.
ok, removed from repo and added in 1Password
sonrohan
pushed a commit
that referenced
this pull request
Nov 8, 2021
* ci: Publish RxAndroidBle fork to Artifactory (DROID-1123) * remove artifactory credentials
sonrohan
pushed a commit
that referenced
this pull request
Nov 8, 2021
* ci: Publish RxAndroidBle fork to Artifactory (DROID-1123) * remove artifactory credentials
sonrohan
pushed a commit
that referenced
this pull request
Nov 8, 2021
* ci: Publish RxAndroidBle fork to Artifactory (DROID-1123) * remove artifactory credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.