Copy the spendable-balances cli query command from upstream v0.47.x. #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iramiller
approved these changes
Jul 29, 2023
SpicyLemon
added a commit
that referenced
this pull request
Aug 11, 2023
SpicyLemon
added a commit
that referenced
this pull request
Aug 11, 2023
…, Locked Coins No Delegate (#582) (#584) * Copy the spendable-balances cli query command from upstream v0.47.x. (#580) * Allow MsgMultiSend to have multiple inputs when there's only one output. (#581) * Update InputOutput coins to allow multiple senders if there's a single receiver. So it's one-to-one, one-to-many, or many-to-one, but not many-to-many. * Add changelog entry. * Prevent locked coins from being delegated. (#582) * [1607]: Move the UnvestedCoins GetLockedCoinsFn to its own file. * [1607]: Add the ability to bypass the vesting locked coins function. * [1607]: Rename the bypass funcs to include vesting since it's in the types package in the bank module, so it's not as clear as the others. * [1607]: Pay attention to locked coins in DelegateCoins too, but bypass the vesting locked coins funciton since it's purposfully not applied there. But we want the other locked coins stuff to still go. * [1607]: Add unit tests on the locked coins behaviors. * [1607]: Put the UnvestedCoins function back in view.go and get rid of the locked_coins.go file. * [1607]: Add changelog entry. * [1607]: Fix use of InputOutputCoins after merge. * [1607]: Make SimulateFromSeed return the last block time used so restarted stuff can pretend to be at that time too. * [1607]: Use SpendableCoins with vesting bypass for the staking simulation operations. * [1607]: Fix a bank test that was failing because I changed an error message. * [1607]: Fix the staking simulation operations to properly handle funds locked outside of vesting. * [1607]: Fix the test-sim-benchmark-invariants make target. * [1607]: Update the changelog. * Add changelog entry for 580.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in the
spendable-balancesfrom v0.47 of the SDK.v0.46 of the SDK already has the
SpendableBalancesgrpc query endpoint, just not the CLI command for it.v0.47 has the CLI command, but also has a
SpendableBalancesByDenomquery that isn't yet in our version of the SDK. The CLI command has a--denomflag that, if provided uses the denom-specific version of the query instead of the one for all balances. So the version of the command in this PR is a little different from the v0.47 version of the command because I had to remove that denom-specific functionality.For reference, here's the SDK's version which I copied/tweaked: https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/x/bank/client/cli/query.go#L112-L170
I didn't bring over any unit tests for it because v0.47 included a massive overhaul to how tests are done, and they couldn't be easily copy/pasted/fixed.
I did, however, wire this up to a local version of the provenance repo, and added some unit tests in there dealing with the escrow module, making sure that things in escrow are removed from the spendable balances.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change