Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Dismiss Produce Message pane after Send #2672

Closed
gabrieljones opened this issue Sep 30, 2022 · 2 comments · Fixed by #2854
Closed

Don't Dismiss Produce Message pane after Send #2672

gabrieljones opened this issue Sep 30, 2022 · 2 comments · Fixed by #2854
Assignees
@David-DB88
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Milestone
0.7

Comments

@gabrieljones
Copy link

gabrieljones commented Sep 30, 2022 •
edited
Loading

Which version of the app are you running?

vv0.4.0(521ba0c)

Is your proposal related to a problem?

After clicking Send in Produce Message pane UI shift back to the Messages pane and resets the Produce Message field contents.

Describe the solution you'd like

After clicking Send in Produce Message pane UI stays on the Produce Message pane and the field contents remain as entered without being reset to a new random lorem ipsum.
@gabrieljones gabrieljones added status/triage Issues pending maintainers triage type/feature A new feature labels Sep 30, 2022
@iliax
Copy link
Contributor

iliax commented Oct 3, 2022

Hello @gabrieljones, thank you for suggestion.

I personally find this behaviour useful, especially when you need to send similar messages with minor changes. Maybe we can add explicit "Generate random" button in produce dialog.
We will discuss it internally and implement it either way.

cc @Haarolean @workshur

@iliax iliax added the status/needs-attention Collective discussion is required label Oct 3, 2022
@Haarolean
Copy link
Contributor

To do:

  1. In the produce message pane add a new checkbox "Keep the contents", unchecked by default
  2. If the checkbox is being checked, upon producing a message do the following:
  1. do not close the pane upon producing the message
  2. Do not alter key/value content in any way

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted hacktoberfest and removed status/triage Issues pending maintainers triage type/feature A new feature status/needs-attention Collective discussion is required labels Oct 7, 2022
winnie-chiu added a commit to winnie-chiu/kafka-ui that referenced this issue Nov 1, 2022
@winnie-chiu
Don't Dismiss Produce Message pane after Send (provectus#2672)
0d6fe23
@Haarolean Haarolean linked a pull request Nov 1, 2022 that will close this issue
Don't Dismiss Produce Message pane after Send #2854
Merged
13 tasks
@Haarolean Haarolean added this to the 0.5 milestone Nov 1, 2022
@Haarolean Haarolean modified the milestones: 0.5, 0.6 Dec 7, 2022
@Haarolean Haarolean removed this from the 0.6 milestone Feb 15, 2023
@Haarolean Haarolean added this to the 0.7 milestone Apr 26, 2023
@Haarolean Haarolean mentioned this issue Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@David-DB88 David-DB88

Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Don't Dismiss Produce Message pane after Send winnie-chiu/kafka-ui
4 participants
@iliax @Haarolean @gabrieljones @David-DB88