Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #586

Merged
merged 1 commit into from
Jun 19, 2024
Merged

chore: fix some comments #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/rules/naming/named-parameters-mapping.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ mapping(string name => uint256 balance) public users;
mapping(address owner => mapping(address token => uint256 balance)) public tokenBalances;
```

#### Main key of mapping is enforced. On nested mappings other naming are not neccesary
#### Main key of mapping is enforced. On nested mappings other naming are not necessary

```solidity
mapping(address owner => mapping(address => uint256)) public tokenBalances;
Expand Down
2 changes: 1 addition & 1 deletion e2e/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('e2e', function () {
const PATH = '03-no-empty-blocks'
const { PREFIX, SUFFIX } = prepareContext(PATH)

it('No contracts to lint should fail with appropiate message', function () {
it('No contracts to lint should fail with appropriate message', function () {
const { code, stderr } = shell.exec(`${NODE}solhint Foo1.sol ${SUFFIX}`)

expect(code).to.equal(EXIT_CODES.BAD_OPTIONS)
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/naming/func-named-parameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class FunctionNamedParametersChecker extends BaseChecker {
if (qtyNamed === 0 && qtyArgs > this.maxUnnamedArguments) {
this.error(
node,
`Named parameters missing. MIN unnamed argumenst is ${this.maxUnnamedArguments}`
`Named parameters missing. MIN unnamed arguments is ${this.maxUnnamedArguments}`
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/naming/named-parameters-mapping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const meta = {
},
{
description:
'Main key of mapping is enforced. On nested mappings other naming are not neccesary',
'Main key of mapping is enforced. On nested mappings other naming are not necessary',
code: 'mapping(address owner => mapping(address => uint256)) public tokenBalances;',
},
{
Expand Down
6 changes: 3 additions & 3 deletions test/rules/naming/func-named-parameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('Linter - func-named-parameters', () => {
assertErrorCount(report, 1)
assertErrorMessage(
report,
`Named parameters missing. MIN unnamed argumenst is ${
`Named parameters missing. MIN unnamed arguments is ${
minUnnamed < DEFAULT_MIN_UNNAMED_ARGUMENTS ? DEFAULT_MIN_UNNAMED_ARGUMENTS : minUnnamed
}`
)
Expand Down Expand Up @@ -90,7 +90,7 @@ describe('Linter - func-named-parameters', () => {

assertErrorMessage(
report,
`Named parameters missing. MIN unnamed argumenst is ${DEFAULT_MIN_UNNAMED_ARGUMENTS}`
`Named parameters missing. MIN unnamed arguments is ${DEFAULT_MIN_UNNAMED_ARGUMENTS}`
)
})

Expand All @@ -106,7 +106,7 @@ describe('Linter - func-named-parameters', () => {

assertErrorMessage(
report,
`Named parameters missing. MIN unnamed argumenst is ${DEFAULT_MIN_UNNAMED_ARGUMENTS}`
`Named parameters missing. MIN unnamed arguments is ${DEFAULT_MIN_UNNAMED_ARGUMENTS}`
)
})
})
Loading