Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 #1466

pRoy24 · 2020-12-17T23:44:41Z

Fixed the previous round of comments.
Added badge as defined in the mockup.
Refactored to make it work with ETH as the base and cETH as the underlying collateral.
Tested on Rinkeby with ETH -> cETH and dai -> cDAI pairs.

Please note that you need to run yarn install since this feature uses Big.js version 6.0.0

pimato · 2021-01-15T15:38:06Z

just played around with it on Rinkeby and I am getting an error after clicking on circle button to enable it:

Steps to reproduce:

Connect to Rinkeby
Create Market
Configure Market:

4) Click Continue 5) Click enable Compound circle button 6) BUG: App crashes

pRoy24 · 2021-01-16T10:20:55Z

just played around with it on Rinkeby and I am getting an error after clicking on circle button to enable it:

Steps to reproduce:

Connect to Rinkeby

Create Market

Configure Market:

Click Continue 5) Click enable Compound circle button 6) BUG: App crashes

You need to run Yarn install since it uses Big.js version 6.0.0 for the prec function

pimato · 2021-01-18T12:15:00Z

Hey @pRoy24 , once I enable compound the pool number is jumping around:

pimato · 2021-01-18T12:24:05Z

Every market info component here has a svg in 24x24. The compound svg you included is 16x16:

please use this svg:
comp.svg.zip

pimato · 2021-01-18T12:25:06Z

Please remove the styling if the circle button is active, currently if you hover over it you see the border is popping up:

pimato · 2021-01-18T12:26:33Z

If you hover over the compound info the icon is turning blue, which is not according my design specification. Currently:

Should:

onHover color: #00897B

pimato · 2021-01-18T12:28:05Z

Just looking at the price of the outcomes here:

I believe those prices are in cDAI and not in DAI right?
I think this is also the case with the shares!

Are we able to calculate all of this to DAI?

pimato · 2021-01-18T12:33:31Z

Looks like after I done a swap, the form is not resetting which is our default.

Doing a swap:

after the swap is done, the inputfield is still filled with the number 2 and I see order details:

It should reset the order form as we do on default.

pimato · 2021-01-19T09:06:16Z

Please remove the styling if the circle button is active, currently if you hover over it you see the border is popping up:

it looks like now the the border got removed when holding on-click:

pimato · 2021-01-19T09:15:17Z

The compound icon is still not correct, currently:

should:

did you actually replaced the svg which I provided?
The currently used svg has viewBox="0 0 16 16" but should actually have viewBox="0 0 24 24"

pimato · 2021-01-19T09:18:48Z

If you hover over the compound info the icon is turning blue, which is not according my design specification. Currently:

Should:

onHover color: #00897B

you changed the normal color to #00897B, but you actually should use #00897B as the hover color for the icon and the text.

pimato

see comments.

…as to transforming tokens as opposed to transforming prices

Mi-Lan

Small changes...

Mi-Lan · 2021-01-20T22:29:22Z

app/src/components/market/common/add_compound_service/index.tsx

+const ServiceTextWrapper = styled.div`
+  width: 90%;
+`
+
+const ServiceCheckWrapper = styled.div`
+  width: 10%;
+  color: transparent;


I dont think defining static values to width here is neccesary. I would suggest just adding
justify-content: space-between; to the parent element that is 100% and omitting width for these two values. The reason for this is because 10% is slightly more than 40px and creates this unnecessary margin...

Mi-Lan · 2021-01-20T22:32:53Z

app/src/util/networks.ts

  cdai: {
    symbol: 'cDAI',
-    decimals: 18,


Would be good to have consistent letter formatting for both currencies. To make them both capital or with first letter Uppercase (which is according to design...

Yup, makes sense refactored to include the change.

pRoy24 added 11 commits December 16, 2020 10:51

saving

e657c99

stashing

a80a44a

saving

f41006f

saving

ecdd4af

saving

1481921

saving

7b58d7c

fixed interest rates for different compound types

cf021f4

adding files

b91e7dc

update readme

d4a8284

update readme

241919b

adding files

dbb22d8

pRoy24 changed the title ~~Gitcoin bounty submission. https://gitcoin.co/issue/dxdaohackathon/omen-exchange/1/100024191~~ Gitcoin bounty submission. https://gitcoin.co/issue/dxdaohackathon/omen-exchange/1/100024191 by proy24 Dec 17, 2020

Saving

faffce3

pimato requested review from kadenzipfel, hexyls, pimato and Mi-Lan December 21, 2020 10:17

pRoy24 added 5 commits December 30, 2020 10:47

update add remove flows

ba855af

adding files

86f756e

add files

0005bd5

merge with remote master

dfd2e5d

rebase to master

7160a1b

pRoy24 force-pushed the master branch from 56db758 to 7160a1b Compare January 1, 2021 11:32

pRoy24 marked this pull request as draft January 1, 2021 11:33

pRoy24 added 2 commits January 4, 2021 08:30

fix linter

cf0c61f

adding files

0be6ea0

pRoy24 changed the title ~~Gitcoin bounty submission. https://gitcoin.co/issue/dxdaohackathon/omen-exchange/1/100024191 by proy24~~ Compound integration with Omen Markets. Gitcoin bounty dxdaohackathon/omen-exchange/1/100024191 Jan 4, 2021

pRoy24 added 2 commits January 4, 2021 10:05

fix logic for add liquidity using base token

97759b8

finish functionalities, some cleanup still needed, but feature complete

c22422c

pRoy24 marked this pull request as ready for review January 5, 2021 04:28

pRoy24 added 5 commits January 18, 2021 15:15

rebase, address comments

574b148

fix dropdown position for withdraw dropdown

7650eac

Merge branch 'master' into master

abe42d6

updates to the calculation to minimize dust

a9f3dfd

Merge branch 'master' of https://github.com/pRoy24/omen-exchange

f977f80

pimato suggested changes Jan 19, 2021

View reviewed changes

pRoy24 added 4 commits January 20, 2021 16:19

address style comments, changes related to discussion on men channel …

3cdb883

…as to transforming tokens as opposed to transforming prices

rebase to master

452a358

pass down compound service from top level component, cleanup

050f7c3

rebase to master fix merge conflicts

15491c8

Mi-Lan suggested changes Jan 20, 2021

View reviewed changes

pRoy24 added 4 commits January 21, 2021 08:46

adding files

2a07bc9

code review fixes

80af976

rebase to master

234cf36

fix some remaining merge conflicts

078da4d

pRoy24 mentioned this pull request Jan 22, 2021

Feature/compound integration #1570

Merged

19 tasks

pRoy24 closed this Jan 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 #1466

Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 #1466

pRoy24 commented Dec 17, 2020 •

edited

Loading

pimato commented Jan 15, 2021

pRoy24 commented Jan 16, 2021

pimato commented Jan 18, 2021 •

edited

Loading

pimato commented Jan 18, 2021

pimato commented Jan 18, 2021

pimato commented Jan 18, 2021

pimato commented Jan 18, 2021 •

edited

Loading

pimato commented Jan 18, 2021

pimato commented Jan 19, 2021

pimato commented Jan 19, 2021 •

edited

Loading

pimato commented Jan 19, 2021

pimato left a comment

Mi-Lan left a comment

Mi-Lan Jan 20, 2021

pRoy24 Jan 21, 2021

Mi-Lan Jan 20, 2021

pRoy24 Jan 21, 2021

Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 #1466

Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 #1466

Conversation

pRoy24 commented Dec 17, 2020 • edited Loading

pimato commented Jan 15, 2021

pRoy24 commented Jan 16, 2021

pimato commented Jan 18, 2021 • edited Loading

pimato commented Jan 18, 2021

pimato commented Jan 18, 2021

pimato commented Jan 18, 2021

pimato commented Jan 18, 2021 • edited Loading

pimato commented Jan 18, 2021

pimato commented Jan 19, 2021

pimato commented Jan 19, 2021 • edited Loading

pimato commented Jan 19, 2021

pimato left a comment

Choose a reason for hiding this comment

Mi-Lan left a comment

Choose a reason for hiding this comment

Mi-Lan Jan 20, 2021

Choose a reason for hiding this comment

pRoy24 Jan 21, 2021

Choose a reason for hiding this comment

Mi-Lan Jan 20, 2021

Choose a reason for hiding this comment

pRoy24 Jan 21, 2021

Choose a reason for hiding this comment

pRoy24 commented Dec 17, 2020 •

edited

Loading

pimato commented Jan 18, 2021 •

edited

Loading

pimato commented Jan 18, 2021 •

edited

Loading

pimato commented Jan 19, 2021 •

edited

Loading