[Bazel/C++] Move core C++ implementation to //src/google/protobuf package. #9988
Conversation
| # Built-in runtime types | ||
| # Source files: these are aliases to a filegroup, not a `proto_library`. | ||
| # | ||
| # (This is _probably_ not what you want.) |
There was a problem hiding this comment.
Is this in place just for compatibility? Do we have specific users that we know of? Can we remove this once we burn them down?
There was a problem hiding this comment.
For the old name lite_well_known_protos, it's compatibility and that name can probably go away soon-ish. But I think we will probably need to provide access to the sources for the foreseeable future (so well_known_type_protos probably ought to stick around), and I sort of think that the root package is the right place to put it. But that can be a future change.
BUILD.bazel
Outdated
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| # adapt_proto_library( |
There was a problem hiding this comment.
Oops, thanks. Removed it.
|
I think this PR broke existing Bazel users depending on the well known types in this repository. The error I'm seeing in my repository is . I fixed it by changing the reference to |
Sorry about that... the "well_known_protos" target went away in #9915, to distinguish between the Well-Known Types and the built-in runtime protos. Your fix sounds correct, if the WKTs are what you want. Depending on how you use the WKTs, though, you might be able to use the finer-grained targets, too. I'll go ahead and add this target back with a deprecation warning (see #10061). |
This is somewhat of a rough cut, since it doesn't split apart the lite and full targets, or unit tests.