-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Support x64-mingw-ucrt platform #9963
Ruby: Support x64-mingw-ucrt platform #9963
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
c2fc7bd
to
efe526a
Compare
…h Windows Ruby Installer uses as of Ruby 3.1
efe526a
to
9254853
Compare
I've confirmed that this successfully built the Ruby gem packages in It installs on Windows Ruby 3.1
|
@haberman are you still the right contact for this package? |
We should cherry-pick this to the release branch so that it goes out in the the 3.21.0 release. |
This PR adds support for Ruby
x64-mingw-ucrt
platform, which is the new platform Windows Ruby Installer uses as of Ruby 3.1.As of 3.21.0.rc.1 protobuf is not including a
x64-mingw-ucrt
gem package. Refer to nokogiri for the expectedx64-mingw-ucrt
package we should see.Refer to this GRPC ticket for details: grpc/grpc#29666