Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Support x64-mingw-ucrt platform #9963

Merged

Conversation

johnnyshields
Copy link
Contributor

@johnnyshields johnnyshields commented May 13, 2022

This PR adds support for Ruby x64-mingw-ucrt platform, which is the new platform Windows Ruby Installer uses as of Ruby 3.1.

As of 3.21.0.rc.1 protobuf is not including a x64-mingw-ucrt gem package. Refer to nokogiri for the expected x64-mingw-ucrt package we should see.

Refer to this GRPC ticket for details: grpc/grpc#29666

@google-cla
Copy link

google-cla bot commented May 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@johnnyshields johnnyshields changed the title Ruby: Support x64-mingw-ucrt platform, which is the new platform whic… Ruby: Support x64-mingw-ucrt platform May 13, 2022
@johnnyshields johnnyshields force-pushed the ruby-x64-mingw-ucrt-support branch from c2fc7bd to efe526a Compare May 13, 2022 17:53
…h Windows Ruby Installer uses as of Ruby 3.1
@johnnyshields
Copy link
Contributor Author

johnnyshields commented May 13, 2022

I've confirmed that this successfully built the Ruby gem packages in ruby/pkg dir:

image

It installs on Windows Ruby 3.1

C:\workspace\protobuf>gem install --local ruby\pkg\google-protobuf-3.20.1-x64-mingw-ucrt.gem
Successfully installed google-protobuf-3.20.1-x64-mingw-ucrt
Parsing documentation for google-protobuf-3.20.1-x64-mingw-ucrt
Installing ri documentation for google-protobuf-3.20.1-x64-mingw-ucrt
Done installing documentation for google-protobuf after 1 seconds
1 gem installed

@nicolasnoble
Copy link
Contributor

@haberman are you still the right contact for this package?

@haberman haberman merged commit 9be7dd1 into protocolbuffers:main May 13, 2022
@haberman
Copy link
Member

We should cherry-pick this to the release branch so that it goes out in the the 3.21.0 release.

@johnnyshields johnnyshields deleted the ruby-x64-mingw-ucrt-support branch May 14, 2022 02:39
@johnnyshields
Copy link
Contributor Author

@haberman thanks for merging! Backport done here: #9969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants