Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve range handling logic of RepeatedField #9799

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

JasonLunn
Copy link
Contributor

Adds support for negative start or end and exclusive ends.

Includes regression tests contributed mostly by @lucthev. Fixes #9751.

…egative start or ends and exclusive ends.

Includes regression tests contributed mostly by @lucthev. Fixes protocolbuffers#9751.
@JasonLunn JasonLunn added ruby jruby Issues unique to the JRuby interpreter release notes: yes labels Apr 18, 2022
@JasonLunn JasonLunn requested a review from haberman April 18, 2022 15:57
Copy link
Contributor

@perezd perezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JasonLunn JasonLunn removed the request for review from haberman April 19, 2022 14:00
@JasonLunn JasonLunn merged commit 3a477b1 into protocolbuffers:main Apr 19, 2022
@JasonLunn JasonLunn deleted the fix_9751 branch April 19, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jruby Issues unique to the JRuby interpreter ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JRuby] RepeatedField#[] inconsistencies with negative ranges
3 participants