Do not use range based UTF-8 validation in truffleruby #9769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
added
platform related
haberman
approved these changes
Apr 8, 2022
|
Upstream has fixed the bug, but it won't be able to make the fix into the next release of truffleruby later this month. So it will be another 3~4 months for the upstream fix to land into a stable release. |
|
Both fixes are compatible (they both disable the SSE4_1 path on TruffleRuby), so I think it makes sense to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
missing LLVM builtin: llvm.x86.ssse3.pshuf.b.128in oracle/truffleruby#2640 by forcing it to compile with oldutf8_naivewhen the macroTRUFFLERUBYis defined.