Implement respond_to? in RubyMessage
#9677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented by `method_missing` return true. Add regression tests. Fix null pointer exceptions exposed by new unit tests. Code cleanup: remove test code that was skipping several unit tests only on JRuby. Fixes issue protocolbuffers#9202.
… proto2 vs proto3.
…t respond_to? does not depend on whether the oneof is currently cleared.
…t respond_to? does not depend on whether the oneof is currently cleared. Code cleanup: reenable more tests on JRuby.
…pting to assign to a oneof.
Code cleanup: Eliminate noisy warnings when running tests by 1) removing or using unused variables 2) wrapping ambiguous parameters in parentheses
perezd
approved these changes
Mar 28, 2022
ruby/tests/repeated_field_test.rb
Outdated
| @@ -487,7 +487,7 @@ def test_shift | |||
| def test_shuffle! | |||
| m = TestMessage.new | |||
| m.repeated_string += %w(foo bar baz) | |||
| orig_repeated_string = m.repeated_string.clone | |||
| # orig_repeated_string = m.repeated_string.clone | |||
There was a problem hiding this comment.
Should this be uncommented?
ruby/tests/repeated_field_test.rb
Outdated
| assert_equal -1.01, m.repeated_float.pop.round(2) | ||
| assert_equal -1.0000000000002, m.repeated_double.pop | ||
| assert_equal -1.0000000000001, m.repeated_double.pop | ||
| assert_equal( -1.02, m.repeated_float.pop.round(2) ) |
There was a problem hiding this comment.
all of these edits seem irrelevant to the goal of the PR, I'd revert for noise sake.
| } | ||
| } | ||
| boolean includePrivate = false; | ||
| if ( args.length == 2 ) { |
JasonLunn
added a commit
to JasonLunn/protobuf
that referenced
this pull request
Mar 31, 2022
All synthetic methods implemented by `method_missing` are now supported by `respond_to?`. Fixes issue protocolbuffers#9202. * Fix null pointer exceptions exposed by new regression tests. * Fix clear_ on oneofs so that it is safe to call repeatedly and so that respond_to? does not depend on whether the oneof is currently cleared. * Code cleanup: reenable more tests on JRuby. * Align JRuby behavior with CRuby by throwing a RuntimeError when attempting to assign to a oneof. (cherry picked from commit 8e7f936)
Merged
mkruskal-google
added a commit
that referenced
this pull request
Apr 7, 2022
* Fix NPE during encoding and add regression test for issue 9507. (cherry picked from commit 58e320a) * Implement `respond_to?` in RubyMessage (#9677) All synthetic methods implemented by `method_missing` are now supported by `respond_to?`. Fixes issue #9202. * Fix null pointer exceptions exposed by new regression tests. * Fix clear_ on oneofs so that it is safe to call repeatedly and so that respond_to? does not depend on whether the oneof is currently cleared. * Code cleanup: reenable more tests on JRuby. * Align JRuby behavior with CRuby by throwing a RuntimeError when attempting to assign to a oneof. (cherry picked from commit 8e7f936) * Update protobuf version * Merge pull request #9727 from mlocati/build-packaged-php-extension Fix building packaged PHP extension (cherry picked from commit 7f9901c) * Update protobuf version * Update changelogs for 3.20.1-rc1 Co-authored-by: Jason Lunn <[email protected]> Co-authored-by: Jorg Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All synthetic method names implemented by
method_missingreturn true. Add regression tests.method_missingexposed by new unit tests.clear_on a oneof field would throw an exception.RuntimeErrorrather than aNoMethodErrorwhen attempting to assign to a oneof.Code cleanup: remove test code that was skipping several unit tests only on JRuby.
Fixes issue #9202.