Fix C# generator handling of a field named "none" in a oneof #9636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the test protos are generated; I can easily regenerate them after rebasing, when this is approved. |
|
I was going to wait until #9686 was in, but I'll do that separately. Will regenerate (to update testprotos.pb) and merge. |
|
Have actually found some more places I wasn't fixing up - will fix those and request a re-review. |
jskeet
force-pushed
the
oneof-none-csharp
branch
from
807ebd3 to
8b25276
Compare
|
Thanks Amanda. Will rebase again, look into the MacOS changes, and then merge if it's green. |
When following the instructions directly (for developing on Windows) we should end up with a generator that's easy to run for csharp/generate_protos.sh, and we shouldn't end up trying to stage the build output.
Fixes protocolbuffers#9605 (tests in next commit)
jskeet
force-pushed
the
oneof-none-csharp
branch
from
8b25276 to
99fad02
Compare
This doesn't test *all* possibilities (e.g. the field being a wrapper, or a message field, etc) - but I'm fairly confident that I found all the places referring to the case.
jskeet
force-pushed
the
oneof-none-csharp
branch
from
99fad02 to
10e1fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #9605.
(Review one commit at a time; the final commit is just generated.)