Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the ObjC support conditional to darwin. #9543

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Make the ObjC support conditional to darwin. #9543

merged 1 commit into from
Feb 24, 2022

Conversation

thomasvl
Copy link
Contributor

Fixes #9392

@thomasvl thomasvl marked this pull request as draft February 24, 2022 19:40
@thomasvl thomasvl marked this pull request as ready for review February 24, 2022 20:11
@thomasvl
Copy link
Contributor Author

thomasvl commented Feb 24, 2022 •
edited
Loading

Clearing draft incase that's why kokoro wasn't testing this yet.

@thomasvl thomasvl force-pushed the make_objc_test_darwin_specific branch from 985517f to ecff97f Compare February 24, 2022 21:12
@thomasvl thomasvl force-pushed the make_objc_test_darwin_specific branch from ecff97f to 818f655 Compare February 24, 2022 21:21
@thomasvl thomasvl requested a review from acozzette February 24, 2022 22:06
@thomasvl
Copy link
Contributor Author

Looks like the snippet from the original issue works (passes kokoro, and my local mac build still has the objc support).

@Arfrever fyi

acozzette
acozzette approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@acozzette acozzette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we will likely be deleting the autotools build soon.

@Arfrever
Copy link
Contributor

@acozzette

If you are planning to recommend using cmake build system, why is cmake build system still documented as being only for Windows?

@acozzette
Copy link
Member

Our documentation for the CMake build is way out of date. We need to update it to say that it is for all platforms.

@thomasvl
Copy link
Contributor Author

src/README.md also seems to steer away from cmake.

@thomasvl thomasvl merged commit 6a77c9b into protocolbuffers:master Feb 24, 2022
@thomasvl thomasvl deleted the make_objc_test_darwin_specific branch February 24, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

Assignees
No one assigned
Labels
objective-c
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable check for Objective C compiler (AC_PROG_OBJC) on non-macOS systems
4 participants
@thomasvl @Arfrever @acozzette @protobuf-kokoro