-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile errors on case-sensitive APFS #7007
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Oh, I found these closed pull requests... Override CocoaPods module to lowercase by paulb777 · Pull Request #6464 · protocolbuffers/protobuf Fix CocoaPods case warnings by paulb777 · Pull Request #6190 · protocolbuffers/protobuf What should I do for this compile error? I know that this patch solves my compile errors, but is this the correct way? I'm using Xcode Version 11.3 (11C29), other software versions:
|
As you see from those other issues, there isn't a clear "fix" at the moment. This PR would cause warnings for some of the other setups because the tree of directories/links created by cocoapods isn't consistent (some times it is the package name, some times it is the module name). So short of doing what is suggested in some of those where we abandon the Protobuf pod name for protobuf and thus require everyone to migrate, there doesn't seem to be a real solution (and during that migration folks could run into double definitions when they get both). |
ps - #6803 is the currently open issue for tracking the problem |
Thank you reviewing and telling me the current status! |
Hi. I couldn't add protobuf to iOS App. using CocoaPods with compile errors:
I figured out
Any.pbobjc.h
is located onProtobuf
, notprotobuf
, and also, my disk is formatted as case-sensitive APFS. So that the objc compiler cannot find the header.Here is my podfile:
This patch may also fixes: invertase/react-native-firebase#2780