Fix usage of six in //:protobuf_python rule and add import #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the test errors. |
|
The four failed so far do not appear to be failed tests. Each has the error So I don't see what I can do to resolve this when the actual tests themselves run fine in the other pipelines? Do you want a rebase or master-merge? |
|
Alright... Seems it has some errors during last run. |
|
Looks OK on the second time through 🤔 |
anandolee
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
//external:sixworks when protobuf is the root repo, but fails when protobuf is a third party dependency of another workspace.@six//:sixworks in both situations once the relevant workspace rule has been updated to match.Also added six to the protobuf_deps.bzl file.