Updated to latest rules_kotlin #13830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgowroji I think the c++ code just happen to have similar names but it's in fact irrelevant to the breakage, you'll need to update rules_kotlin instead. |
|
Oh okay. @meteorcloudy Thanks for information. |
sgowroji
changed the title
meteorcloudy
suggested changes
Sep 4, 2023
| @@ -199,12 +199,12 @@ FileGenerator::CommonState::CollectMinimalFileDepsContainingExtensionsInternal( | |||
| CollectMinimalFileDepsContainingExtensionsInternal(dep); | |||
|
|
|||
| // Everything the dep covered, this file will also cover. | |||
| transitive_deps_collector.insert(dep_info.transitive_compile_time_jars.begin(), | |||
| dep_info.transitive_compile_time_jars.end()); | |||
| transitive_deps_collector.insert(dep_info.transitive_deps.begin(), | |||
There was a problem hiding this comment.
Please revert this change.
|
Reverting this PR until there is release from rules_kotlin |
|
@meteorcloudy Can you please review. Thanks! |
meteorcloudy
approved these changes
Sep 8, 2023
|
Merged at cl/563772250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to latest rules_kotlin