Main 202308091812 #13489
Merged
Main 202308091812 #13489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC compilers generate warnings that the default destructor is implicitly deleted, which causes errors on /W1. While this is a pedantic warning (error), we can easily make the deletion explicit to avoid these warnings. PiperOrigin-RevId: 547548886
Explicitly delete the destructor for the internal `Rep` structure.
PiperOrigin-RevId: 542579832
…google-cloud-shared-dependencies PiperOrigin-RevId: 547882989
Put a 4k limit on preallocation to prevent OOM from malformed inputs.
Backport java linkage monitor fix
PiperOrigin-RevId: 548128917
This will be used for tracking the unresolved feature sets from the original proto file. Notable use-cases for this include: * Code generators that need to validate their own features * Runtimes that need to be able to accurately round-trip the original protos PiperOrigin-RevId: 547610367
PiperOrigin-RevId: 547625871
There are 4 different feature sets for every descriptor: * Runtime/resolved - Used to make runtime decisions * Source/resolved - Used to make codegen decisions * Runtime/raw - Used to reason about the original proto file during runtime * Source/raw - Used to validate features during codegen All of these will need to be shipped to code generators. While C++ generators can use the C++ runtime to reconstruct these, they won't end up in the FileDescriptorProtos we send to runtimes. Similarly, non-C++ generators wouldn't be able to get them without duplicating our feature resolution logic. This change adds a helper that allows us to bundle all of these into the protos we send to generators. PiperOrigin-RevId: 547849243
There are 4 different feature sets for every descriptor: * Runtime/resolved - Used to make runtime decisions * Source/resolved - Used to make codegen decisions * Runtime/unresolved - Used to reason about the original proto file during runtime * Source/unresolved - Used to validate features during codegen Plugins will receive all 4 of these. Unresolved features will show up in the `raw_features` fields nested inside `features`. The runtime features will be in the `proto_file` field of the request, while the source features will be in the unstripped `source_file_descriptors` field. PiperOrigin-RevId: 547925275
Editions are still flag-guarded by the `--experimental_editions` flag for now, but once that's removed in a later release generators will need to explicitly specify that their support. This will avoid cases where generators may happen to work for editions but produce incorrect code. PiperOrigin-RevId: 547959326
Backport editions plugin improvements
Add JRuby 9.4 tests and require Ruby version >=2.7
Update protobuf's upb dep to latest 24.x commit.
24.x 202307182032
…eports of compilers falling over due to the size of translation units. PiperOrigin-RevId: 549653990
In OSS mode omit some extern template specializations. We have seen r…
Automated rollback of commit adb2c4b.
This moves all our CI to Bazel 6 and drops the additional parameterization we had on Bazel version. PiperOrigin-RevId: 551986376
ericsalo
requested review from
JasonLunn,
anandolee,
googleberg,
jskeet and
fowles
and removed request for
a team
mkruskal-google
approved these changes
Aug 9, 2023
protobuf-team-bot
added a commit
that referenced
this pull request
Aug 9, 2023
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…2308091812 Main 202308091812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.