Avoid -Wunused-parameter on branch 21.x (already committed in main br…

[Romain-Geissler-1A]

…anch).

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[Romain-Geissler-1A]

Mmmh I am not sure why the CLA bot isn't happy. Normally we (Amadeus) have a corporate agreement signed already since years, which shall cover all @amadeus.com mail addresses. For example it was accepted in #5270.

[fowles]

The linked PR is from "Thomas-Barbier-1A" not you. Is there something you need to do on your side to add your account in?

[Romain-Geissler-1A]

It was fine 2 years ago for me in #7865.

[fowles]

hmm... I have reached out internally to see what is going on here

[fowles]

https://cla.developers.google.com/about#add-contributors suggested you may not be an "authorized contributor" for amadeus

[fowles]

corporate partners give Google a group that they self-administer - only members of the group are considered to be under the CLA. In this case, [email protected] administered by [email protected]

romain.geissler%[email protected] is the account that is actually in the group, so you need to re-sign the commit with this address OR have your group administrator update the group to contain [email protected]

[Romain-Geissler-1A]

Ok thanks for these details. I also started to ask questions around internally, and it seems the people managing this group are currently off till 9th, so let's wait till next week.

[fowles]

ping, still waiting on the CLA

[Romain-Geissler-1A]

Hi,

I am again in the Amadeus Open Source group since couple of seconds, so the CLA issue should finally be fixed. Sorry for the long time we needed on our side to resolve this.

Cheers,
Romain

[haberman]

It looks like the CLA issue is resolved. @fowles want to take another look?

[haberman]

@Romain-Geissler-1A could you rebase onto main so that we get all of the updated GitHub Actions tests?

Sorry for the trouble, you caught us in the middle of a migration to GHA.

[Romain-Geissler-1A]

@haberman Sorry your last message slipped though my many mails. I have just rebased.

[fowles]

Sorry for the long delay on this. We ended up fixing this in a different way, but #12445 should accomplish the same thing.