Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR #9981 into 21.x branch #10000

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented May 19, 2022

.NET 7 (currently in preview) introduces a warning (CS8981) which is triggered by the use of namespace aliases within generated code.
We don't expect the aliases chosen to ever cause conflicts with C# keywords, so the generated code now suppresses this warning.

@jskeet
Copy link
Contributor Author

jskeet commented May 19, 2022

(Note: we could add this into the release-notes; the original PR has "relnotes: no" but we could do so if we wanted to. Let me know if you'd like me to write up a description.)

@deannagarcia
Copy link
Member

If you add a description to this PR I can go ahead and add that to the release notes!

@jskeet
Copy link
Contributor Author

jskeet commented May 19, 2022

@deannagarcia: Done - hope the description makes sense!

@deannagarcia deannagarcia merged commit d031130 into protocolbuffers:21.x May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants