You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Don't drop parser warnings on the floor
Fix#9343.
* Convert "missing syntax" warning to an actual warning
For some reason this warning was emitted as a log message rather than a
structured warning. Convert it to use the AddWarning API so that it gets
emitted with a file and line number by protoc, and is visible via the
error collection interface during programmatic use.
* Remove CaptureTestStderr() call
CaptureTestStderr() and GetCapturedTestStderr() have to be paired with each other.
* Adjust tests for new warnings
A few tests now produce warnings that they didn't before, but were
expecting not to see any stderr output. Adjust the tests accordingly.
Co-authored-by: Adam Cozzette <[email protected]>
What version of protobuf and what language are you using?
Version: master
Language: n/a
What operating system (Linux, Windows, ...) and version?
macOS 12.0 (but not applicable)
What runtime / compiler are you using (e.g., python version or gcc version)
n/a
What did you do?
Invoked
protoc --descriptor_set_out=/dev/null bad.proto
on this input:What did you expect to see
This warning about snake case names:
protobuf/src/google/protobuf/compiler/parser.cc
Lines 765 to 767 in 01e84b1
What did you see instead?
Nothing.
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
The text was updated successfully, but these errors were encountered: