Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake build does not install {go,java}_features.proto #19735

Closed
jrick opened this issue Dec 19, 2024 · 0 comments · Fixed by #19758
Closed

cmake build does not install {go,java}_features.proto #19735

jrick opened this issue Dec 19, 2024 · 0 comments · Fixed by #19758
Assignees

Comments

@jrick
Copy link

jrick commented Dec 19, 2024

What version of protobuf and what language are you using?
Version: 29.1

What operating system (Linux, Windows, ...) and version?

Observed on both OpenBSD and Linux.

What runtime / compiler are you using (e.g., python version or gcc version)

n/a

What did you do?
Steps to reproduce the behavior:

  1. build and install using cmake rather than bazel.

What did you expect to see

The same installed files as in the official zip release

What did you see instead?

Installation is missing go_features.proto and java_features.proto is installed to the wrong location.

From cmake build:

$ find . | grep .proto$
./include/google/protobuf/compiler/plugin.proto
./include/google/protobuf/any.proto
./include/google/protobuf/wrappers.proto
./include/google/protobuf/field_mask.proto
./include/google/protobuf/duration.proto
./include/google/protobuf/cpp_features.proto
./include/google/protobuf/descriptor.proto
./include/google/protobuf/timestamp.proto
./include/google/protobuf/source_context.proto
./include/google/protobuf/type.proto
./include/google/protobuf/api.proto
./include/google/protobuf/struct.proto
./include/google/protobuf/empty.proto
./include/java/core/src/main/resources/google/protobuf/java_features.proto

Compared to the extracted .zip:

$ find . | grep .proto$                                                        
./include/google/protobuf/any.proto
./include/google/protobuf/api.proto
./include/google/protobuf/compiler/plugin.proto
./include/google/protobuf/cpp_features.proto
./include/google/protobuf/descriptor.proto
./include/google/protobuf/duration.proto
./include/google/protobuf/empty.proto
./include/google/protobuf/field_mask.proto
./include/google/protobuf/go_features.proto
./include/google/protobuf/java_features.proto
./include/google/protobuf/source_context.proto
./include/google/protobuf/struct.proto
./include/google/protobuf/timestamp.proto
./include/google/protobuf/type.proto
./include/google/protobuf/wrappers.proto

Anything else we should know about your project / environment

@jrick jrick added the untriaged auto added to all issues by default when created. label Dec 19, 2024
@zhangskz zhangskz added cmake editions and removed untriaged auto added to all issues by default when created. labels Dec 19, 2024
copybara-service bot pushed a commit that referenced this issue Dec 20, 2024
Fixes #19735, will be backported to 29.x

PiperOrigin-RevId: 708166250
copybara-service bot pushed a commit that referenced this issue Dec 20, 2024
Fixes #19735, will be backported to 29.x

PiperOrigin-RevId: 708166250
mkruskal-google added a commit that referenced this issue Dec 20, 2024
Fixes #19735, will be backported to 29.x

PiperOrigin-RevId: 708420839
copybara-service bot pushed a commit that referenced this issue Dec 21, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 699324233
copybara-service bot pushed a commit that referenced this issue Dec 21, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 699324233
copybara-service bot pushed a commit that referenced this issue Dec 21, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 699324233
copybara-service bot pushed a commit that referenced this issue Dec 21, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 699324233
copybara-service bot pushed a commit that referenced this issue Dec 23, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 699324233
zhangskz pushed a commit that referenced this issue Dec 23, 2024
* Fix cmake installation location of java and go features

Fixes #19735, will be backported to 29.x

PiperOrigin-RevId: 708420839

* Regenerate stale files
copybara-service bot pushed a commit that referenced this issue Dec 23, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 699324233
copybara-service bot pushed a commit that referenced this issue Dec 23, 2024
This will help us avoid further bugs like #19735, where we're typically not very aware of how our files get installed as long as everything builds.  With these tests in place, we will need to manually update the golden files whenever we add a new file to users' installations.

PiperOrigin-RevId: 709134471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants