Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the JS generator into a plugin that builds into a binary. #1

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

haberman
Copy link
Member

There is still a bit more work to do before gulp dist will work:

$ gulp dist
[16:50:45] Using gulpfile ~/code/protobuf-javascript/gulpfile.js
[16:50:45] Starting 'dist'...
[16:50:45] Starting 'genproto_wellknowntypes'...

../src: warning: directory does not exist.
Could not make proto path relative: ../src/google/protobuf/any.proto: No such file or directory

[16:50:45] 'genproto_wellknowntypes' errored after 19 ms
[16:50:45] Error: Command failed: sh -c bazel-bin/external/com_google_protobuf/protoc --plugin=protoc-gen-js=bazel-bin/generator/protoc-gen-js --js_out=import_style=commonjs,binary:. -I ../src ../src/google/protobuf/any.proto ../src/google/protobuf/api.proto ../src/google/protobuf/compiler/plugin.proto ../src/google/protobuf/descriptor.proto ../src/google/protobuf/duration.proto ../src/google/protobuf/empty.proto ../src/google/protobuf/field_mask.proto ../src/google/protobuf/source_context.proto ../src/google/protobuf/struct.proto ../src/google/protobuf/timestamp.proto ../src/google/protobuf/type.proto ../src/google/protobuf/wrappers.proto
../src: warning: directory does not exist.
Could not make proto path relative: ../src/google/protobuf/any.proto: No such file or directory

@haberman haberman requested a review from acozzette April 28, 2022 16:51
@haberman haberman merged commit 3561b05 into main Apr 28, 2022
@cho-m cho-m mentioned this pull request Jul 14, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants