Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

remove Travis and CircleCI configs on first deployment of test workflow #44

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Apr 1, 2021

As suggested by @aschmahmann, when we first deploy the go-test workflow to repositories, we should disable Travis and CircleCI. The copy workflow adds commits deleting .travis.yml and .circleci/, IF .github/workflows/go-test.yml doesn't exist yet (and thus will be added in the same PR).

@marten-seemann marten-seemann force-pushed the disable-travis-and-circleci branch from c00fe19 to bbafd75 Compare April 1, 2021 14:18
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think three steps is a bit overkill though. This could be a single step with three conditionals.

@marten-seemann
Copy link
Contributor Author

I think three steps is a bit overkill though. This could be a single step with three conditionals.

True, but steps are cheap. And this way we get a nice visual indication if a step was executed:
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants