Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter not support sub packages #1854

Open
d-enk opened this issue Jan 25, 2023 · 0 comments · May be fixed by #1889
Open

Filter not support sub packages #1854

d-enk opened this issue Jan 25, 2023 · 0 comments · May be fixed by #1889

Comments

@d-enk
Copy link

d-enk commented Jan 25, 2023

protobuf.js version: 7.2.0

If proto package have name like package.sub.v1

The following filter will return the entire package package.sub
{ "messageNames": ["package.sub.v1.Message"] }

This should be more smarter
adellahlou pushed a commit to adellahlou/protobuf.js that referenced this issue May 15, 2023
Updated cli filter option to support proto packages with with subpack…
50ad82b 
…ages.[issue protobufjs#1854]

For example, can now support google.protobuf.Timestamp.
@adellahlou adellahlou linked a pull request May 15, 2023 that will close this issue
Open
@d-enk d-enk mentioned this issue Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed cli filter to support nested-namespace packages [issue #1854] adellahlou/protobuf.js
1 participant
@d-enk