More powerful inclusion/exclusion configuration

[carlio]

Sometimes, as seen here: landscapeio/landscape-issues#36 , the sensible defaults are not helpful. There are several inclusions and exclusion rules that are essentially hardcoded. It'd be useful to expose all of these for edge cases (or rather, cases I forgot to think about!)

[jayclassless]

I've started tinkering with a refactor along the lines of what I mentioned in #28. It should also address #31. You can see it over in my central_finder branch.

It's only a beginning, but seems to work. I'm still working out how best to integrate the pylint tool, since that one works quite a bit differently than the rest.

[techdragon]

@jayclassless thanks for the prompt update, I'll give the https://github.com/jayclassless/prospector/commits/central_finder branch a look and post comments. Do you want the branch feedback on this ticket @jayclassless

[carlio]

@jayclassless great stuff. Most of the tools are very similar (and from the same author, the awesome @florentx) but pylint is a different beast. Pylint has always needed special case workarounds to manipulate it, so feel free to make some extra configuration that only applies to pylint. The point of prospector, after all, is to bring these tools together in a consistent manner and hide the complexity (as much as possible) from the end user!

[carlio]

Also be aware that pylint fiddles with sys.path to help it inspect the imported classes. The current file-finding logic also needs to return a list of directories to append to the path to enable pylint to function correctly.

[techdragon]

It may be desirable to add the ability to silence the pylint import check logic, if possible, given that it doesn't work when inspecting code run in a virtualenv from outside the virtualenv as is the case when used as part of an IDE or editor plugin. Upside is it would make the sys path stuff less integral to using pylint as part of prospector. 

Sent from Molto for iPad

From: carlio
Sent: Tuesday, July 08, 2014 01:12 am
To: landscapeio/prospector
Cc: Samuel Bishop
Subject: Re: [prospector] More powerful inclusion/exclusion configuration (#26)

Also be aware that pylint fiddles with sys.path to help it inspect the imported classes. The current file-finding logic also needs to return a list of directories to append to the path to enable pylint to function correctly.

—
Reply to this email directly or view it on GitHub.

[carlio]

@jayclassless I ended up rolling my own as it was a little urgent given this issue: landscapeio/landscape-issues#70 - turns out that frosted (and probably others) were not using exclusion logic correctly!

[jayclassless]

Ah, cool. Sorry I never got around to finishing what I had started -- endless distractions kept me away.

Hopefully this will kill off the bugs we keep running into with this stuff.