Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isState / isComputed guards to allow all parameter types #45

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix isState / isComputed guards to allow all parameter types #45

merged 2 commits into from
Jan 17, 2025

Conversation

fcrozatier
Copy link
Contributor

Added a simple check to prevent isState and isComputed from erroring on values

@NullVoxPopuli
Copy link
Contributor

Ope, prettier strikes again. Can you address? Thank you!!

@NullVoxPopuli NullVoxPopuli merged commit c3adec8 into proposal-signals:main Jan 17, 2025
3 checks passed
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jan 17, 2025
@NullVoxPopuli NullVoxPopuli changed the title improve guards fix isState / isComputed guards to allow all parameter types Jan 17, 2025
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
@fcrozatier fcrozatier deleted the improve-guards branch January 17, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcrozatier @NullVoxPopuli