Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up IDE found errors/problems. #1950

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix up IDE found errors/problems. #1950

merged 1 commit into from
Jan 24, 2023

Conversation

dereuromark
Copy link
Contributor

PHPStorm found those

@dereuromark dereuromark added this to the 2.0.0 Beta milestone Jan 24, 2023
dereuromark
dereuromark commented Jan 24, 2023
View reviewed changes
src/Propel/Generator/Model/Domain.php
*
* @return void
*/
public function setName(string $name): void
public function setName(?string $name): void
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know if we need this, but the getter is nullable as well

getName(): ?string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense. If you can set it, you probably should be able to unset it

@dereuromark dereuromark requested a review from mringler January 24, 2023 14:00
mringler
mringler approved these changes Jan 24, 2023
View reviewed changes
src/Propel/Generator/Model/Domain.php
*
* @return void
*/
public function setName(string $name): void
public function setName(?string $name): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense. If you can set it, you probably should be able to unset it

@dereuromark dereuromark merged commit 5531e13 into master Jan 24, 2023
@dereuromark dereuromark deleted the cleanup-problems branch January 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michbeck michbeck michbeck approved these changes

@mringler mringler mringler approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.0.0 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @michbeck @mringler