CLN: pandas-dev#28926 Fix mypy errors in pandas/tests/io/parser/conft…

…est.py (pandas-dev#28973)
proost · Dec 19, 2019 · 1aae8f8 · 1aae8f8
1 parent 0a8461f
commit 1aae8f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/pandas/tests/io/parser/conftest.py b/pandas/tests/io/parser/conftest.py
@@ -1,14 +1,15 @@
 import os
+from typing import List, Optional
 
 import pytest
 
 from pandas import read_csv, read_table
 
 
 class BaseParser:
-    engine = None
+    engine = None  # type: Optional[str]
     low_memory = True
-    float_precision_choices = []
+    float_precision_choices = []  # type: List[Optional[str]]
 
     def update_kwargs(self, kwargs):
         kwargs = kwargs.copy()
@@ -59,11 +60,11 @@ def csv1(csv_dir_path):
 
 _py_parsers_only = [_pythonParser]
 _c_parsers_only = [_cParserHighMemory, _cParserLowMemory]
-_all_parsers = _c_parsers_only + _py_parsers_only
+_all_parsers = [*_c_parsers_only, *_py_parsers_only]
 
 _py_parser_ids = ["python"]
 _c_parser_ids = ["c_high", "c_low"]
-_all_parser_ids = _c_parser_ids + _py_parser_ids
+_all_parser_ids = [*_c_parser_ids, *_py_parser_ids]
 
 
 @pytest.fixture(params=_all_parsers, ids=_all_parser_ids)

diff --git a/setup.cfg b/setup.cfg
@@ -205,9 +205,6 @@ ignore_errors=True
 [mypy-pandas.tests.io.json.test_ujson]
 ignore_errors=True
 
-[mypy-pandas.tests.io.parser.conftest]
-ignore_errors=True
-
 [mypy-pandas.tests.io.test_sql]
 ignore_errors=True