Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto paginate responses from the Github API #94

Merged
merged 1 commit into from
Sep 7, 2015

Conversation

jhass
Copy link
Contributor

@jhass jhass commented Sep 6, 2015

By default Octokit only fetches the first 30 comments of a pull request,
on large pull requests that makes the duplicate comment detection fail,
leading to duplicates.

By default Octokit only fetches the first 30 comments of a pull request,
on large pull requests that makes the duplicate comment detection fail,
leading to duplicates.
mmozuras added a commit that referenced this pull request Sep 7, 2015
Auto paginate responses from the Github API
@mmozuras mmozuras merged commit db421d7 into prontolabs:master Sep 7, 2015
@mmozuras
Copy link
Member

mmozuras commented Sep 7, 2015

👏 thanks!

@jhass jhass deleted the ghpr_paginate branch September 7, 2015 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants