Pull request formatter: Find position in full diff and fix commit_id #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.github.com/v3/pulls/comments/#create-a-comment appears to be misleading or wrong, depending on how you interpret it. commit_id is meant to reference the "state" of the PR when creating the commit, that is it references the most recent commit of the PR, always. position is meant to be the position in the full diff, not the position in any single commit's diff. With full diff the combined diff of all commits is meant, as you get for example via /:owner/:repo/pull/:id.diff
|
@jhass thanks, I'll take more time with this PR as I want to test some scenarios myself 😄 |
mmozuras
added a commit
that referenced
this pull request
Sep 20, 2015
Pull request formatter: Find position in full diff and fix commit_id
|
@jhass thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.github.com/v3/pulls/comments/#create-a-comment
appears to be misleading or wrong, depending on how you interpret it.
commit_id is meant to reference the "state" of the PR when creating the
commit, that is it references the most recent commit of the PR, always.
position is meant to be the position in the full diff, not the position
in any single commit's diff.
With full diff the combined diff of all commits is meant, as you get for
example via /:owner/:repo/pull/:id.diff