[Fix #233] Skip reviewing PR without comments #235
Conversation
|
|
||
| context 'with comments' do | ||
| before do | ||
| github.should_receive(:pull_id).once.and_return(pull_id) |
There was a problem hiding this comment.
Is it OK to stub this method and not to deal with ENV['PRONTO_PULL_REQUEST_ID']?
There was a problem hiding this comment.
@ivanovaleksey yup, I think that's fine.
| @@ -39,6 +39,8 @@ def create_pull_comment(comment) | |||
| end | |||
|
|
|||
| def create_pull_request_review(comments) | |||
| return if comments.empty? | |||
There was a problem hiding this comment.
Another place for adding this could be GithubPullRequestReviewFormatter#submit_comments.
Not sure which one should be used.
There was a problem hiding this comment.
@ivanovaleksey I think that it makes sense here. If we'd call the client from someplace else, it should not submit either, not just in this case. 👍
There was a problem hiding this comment.
Yes, that was what I thought about.
|
This is now fixed since 1,5 month, can we please have a release for this? |
|
@mmozuras ping? |
|
@SuperTux88 @denschub sorry about that. Had a rough month in my personal life, which made contributing to OSS more than difficult. This again shows why completing #227 should be a priority. |
|
Released as part of v0.9.4. |
|
In that case: sorry for being annoying. Hope you are better and thank you very much for your work. It is much appreciated. 😻 |
|
@denschub no worries, I understand that hearing nothing from me could've been frustrating 😄. And thank you for the kind words 🙇. |
[Fix prontolabs#233] Skip reviewing PR without comments
Hi @mmozuras,
I tried to fix #233.
Not sure about spec. It seems like
spec/pronto/github_spec.rbuses RSpeccontexts to describe behaviour. And I believeitis supposed to do it.Please take a look.