add TCP StatsD listener support #71
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,12 @@ | |
| package main | ||
|
|
||
| import ( | ||
| "bufio" | ||
| "bytes" | ||
| "encoding/binary" | ||
| "fmt" | ||
| "hash/fnv" | ||
| "io" | ||
| "net" | ||
| "regexp" | ||
| "strconv" | ||
|
|
@@ -289,10 +291,6 @@ func NewExporter(mapper *metricMapper, addSuffix bool) *Exporter { | |
| } | ||
| } | ||
|
|
||
| func buildEvent(statType, metric string, value float64, relative bool, labels map[string]string) (Event, error) { | ||
| switch statType { | ||
| case "c": | ||
|
|
@@ -321,17 +319,6 @@ func buildEvent(statType, metric string, value float64, relative bool, labels ma | |
| } | ||
| } | ||
|
|
||
| func parseDogStatsDTagsToLabels(component string) map[string]string { | ||
| labels := map[string]string{} | ||
| networkStats.WithLabelValues("dogstatsd_tags").Inc() | ||
|
|
@@ -351,105 +338,159 @@ func parseDogStatsDTagsToLabels(component string) map[string]string { | |
| return labels | ||
| } | ||
|
|
||
| func lineToEvents(line string) (events Events) { | ||
| if line == "" { | ||
| return | ||
| } | ||
|
|
||
| elements := strings.SplitN(line, ":", 2) | ||
| if len(elements) < 2 || len(elements[0]) == 0 || !utf8.ValidString(line) { | ||
| networkStats.WithLabelValues("malformed_line").Inc() | ||
| log.Errorln("Bad line from StatsD:", line) | ||
| return | ||
| } | ||
| metric := elements[0] | ||
| var samples []string | ||
| if strings.Contains(elements[1], "|#") { | ||
| // using datadog extensions, disable multi-metrics | ||
| samples = elements[1:] | ||
| } else { | ||
| samples = strings.Split(elements[1], ":") | ||
| } | ||
| samples: | ||
| for _, sample := range samples { | ||
| components := strings.Split(sample, "|") | ||
| samplingFactor := 1.0 | ||
| if len(components) < 2 || len(components) > 4 { | ||
| networkStats.WithLabelValues("malformed_component").Inc() | ||
| log.Errorln("Bad component on line:", line) | ||
| continue | ||
| } | ||
| valueStr, statType := components[0], components[1] | ||
|
|
||
| var relative = false | ||
| if strings.Index(valueStr, "+") == 0 || strings.Index(valueStr, "-") == 0 { | ||
| relative = true | ||
| } | ||
|
|
||
| value, err := strconv.ParseFloat(valueStr, 64) | ||
| if err != nil { | ||
| log.Errorf("Bad value %s on line: %s", valueStr, line) | ||
| networkStats.WithLabelValues("malformed_value").Inc() | ||
| continue | ||
| } | ||
|
|
||
| multiplyEvents := 1 | ||
| labels := map[string]string{} | ||
| if len(components) >= 3 { | ||
| for _, component := range components[2:] { | ||
| if len(component) == 0 { | ||
| log.Errorln("Empty component on line: ", line) | ||
| networkStats.WithLabelValues("malformed_component").Inc() | ||
| continue samples | ||
| } | ||
| } | ||
|
|
||
| for _, component := range components[2:] { | ||
| switch component[0] { | ||
| case '@': | ||
| if statType != "c" && statType != "ms" { | ||
| log.Errorln("Illegal sampling factor for non-counter metric on line", line) | ||
| networkStats.WithLabelValues("illegal_sample_factor").Inc() | ||
| continue | ||
| } | ||
| samplingFactor, err = strconv.ParseFloat(component[1:], 64) | ||
| if err != nil { | ||
| log.Errorf("Invalid sampling factor %s on line %s", component[1:], line) | ||
| networkStats.WithLabelValues("invalid_sample_factor").Inc() | ||
| } | ||
| if samplingFactor == 0 { | ||
| samplingFactor = 1 | ||
| } | ||
|
|
||
| if statType == "c" { | ||
| value /= samplingFactor | ||
| } else if statType == "ms" { | ||
| multiplyEvents = int(1 / samplingFactor) | ||
| } | ||
| case '#': | ||
| labels = parseDogStatsDTagsToLabels(component) | ||
| default: | ||
| log.Errorf("Invalid sampling factor or tag section %s on line %s", components[2], line) | ||
| networkStats.WithLabelValues("invalid_sample_factor").Inc() | ||
| continue | ||
| } | ||
| } | ||
| } | ||
|
|
||
| for i := 0; i < multiplyEvents; i++ { | ||
| event, err := buildEvent(statType, metric, value, relative, labels) | ||
| if err != nil { | ||
| log.Errorf("Error building event on line %s: %s", line, err) | ||
| networkStats.WithLabelValues("illegal_event").Inc() | ||
| continue | ||
| } | ||
| events = append(events, event) | ||
| } | ||
| networkStats.WithLabelValues("legal").Inc() | ||
| } | ||
| return | ||
| } | ||
|
|
||
| type StatsDListener struct { | ||
|
There was a problem hiding this comment. Can we make this There was a problem hiding this comment. i thought UDP is primary and TCP is secondary originally. done rename. |
||
| conn *net.UDPConn | ||
| } | ||
|
|
||
| func (l *StatsDListener) Listen(e chan<- Events) { | ||
| buf := make([]byte, 65535) | ||
| for { | ||
| n, _, err := l.conn.ReadFromUDP(buf) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| l.handlePacket(buf[0:n], e) | ||
| } | ||
| } | ||
|
|
||
| func (l *StatsDListener) handlePacket(packet []byte, e chan<- Events) { | ||
| lines := strings.Split(string(packet), "\n") | ||
| events := Events{} | ||
| for _, line := range lines { | ||
| events = append(events, lineToEvents(line)...) | ||
| } | ||
| e <- events | ||
| } | ||
|
|
||
| type StatsDTCPListener struct { | ||
| conn *net.TCPListener | ||
| } | ||
|
|
||
| func (l *StatsDTCPListener) Listen(e chan<- Events) { | ||
| for { | ||
| c, err := l.conn.AcceptTCP() | ||
| if err != nil { | ||
| log.Fatalf("AcceptTCP failed: %v", err) | ||
| } | ||
| go l.handleConn(c, e) | ||
|
There was a problem hiding this comment. Before calling handleconn (or immediately in it) -- we should probably call There was a problem hiding this comment. UDP needs a 64K buffer, since it will recv all data in one packet. |
||
| } | ||
| } | ||
|
|
||
| func (l *StatsDTCPListener) handleConn(c *net.TCPConn, e chan<- Events) { | ||
| defer c.Close() | ||
|
|
||
| r := bufio.NewReader(c) | ||
| for { | ||
| line, isPrefix, err := r.ReadLine() | ||
|
There was a problem hiding this comment. ReadBytes (https://golang.org/pkg/bufio/#Reader.ReadBytes) would be a better method to use-- from the docs: There was a problem hiding this comment. ReadBytes will read till delimiter or eof, so i think ReadLine is more safe for bogus input with really long line, or no line delimiter at all. :) There was a problem hiding this comment. Fair enough, LGTM then :) Lets merge it! |
||
| if err != nil { | ||
| if err != io.EOF { | ||
| log.Errorf("Read %s failed: %v", c.RemoteAddr(), err) | ||
|
There was a problem hiding this comment. It'd be cool to have metrics for these errors so that operators can set up alerts on misbehaving clients. |
||
| } | ||
| break | ||
| } | ||
| if isPrefix { | ||
| log.Errorf("Read %s failed: line too long", c.RemoteAddr()) | ||
| break | ||
| } | ||
| e <- lineToEvents(string(line)) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the named return variable here as it adds stutter to the function signature and use explicit returns below. It's not a go idiom to use naked returns in such long functions.
https://go-review.googlesource.com/c/20024/