Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS for the web UI + metrics #413

Open
matthiasr opened this issue Dec 1, 2021 · 5 comments
Open

Add TLS for the web UI + metrics #413

matthiasr opened this issue Dec 1, 2021 · 5 comments
Labels
enhancement help wanted PRs for this issue are especially welcome

Comments

@matthiasr
Copy link
Contributor

Use the exporter toolkit to add support for TLS on the HTTP interface. See prometheus/graphite_exporter#175 for an example.
@matthiasr matthiasr added enhancement help wanted PRs for this issue are especially welcome labels Dec 1, 2021
CtrlZvi added a commit to CtrlZvi/statsd_exporter that referenced this issue Oct 23, 2022
@CtrlZvi
Add TLS support via the exporter toolkit
560aacc 
Metrics may contain sensitive information, so it should be possible to
scrape them over an encrypted connection. This requires TLS support.
For consistency with other Prometheus exporters, we use the exporter
toolkit to provide TLS support.

Fixes prometheus#413.
CtrlZvi added a commit to CtrlZvi/statsd_exporter that referenced this issue Oct 23, 2022
@CtrlZvi
Add TLS support via the exporter toolkit
54bd6fa 
Metrics may contain sensitive information, so it should be possible to
scrape them over an encrypted connection. This requires TLS support.
For consistency with other Prometheus exporters, we use the exporter
toolkit to provide TLS support.

Fixes prometheus#413.
@networkException
Copy link

@CtrlZvi I saw that you have an implementation of this, would you mind upstreaming it? Or if not (as in you don't want to deal with the review process) could I submit your change as a pull request on your behalf?

@CtrlZvi
Copy link

CtrlZvi commented Dec 16, 2022

Dunno why I didn't convert that commit to a PR. I'll take a look at it this weekend to ensure it's still up to date and get it turned into a PR (assuming the reason I didn't submit it isn't that it doesn't work).

@jsabater
Copy link

jsabater commented Jan 8, 2025

Hello everyone! What is the status of the above-mentioned pull request? I'd be very interested in having statsd_exporter support TLS on the HTTP metrics interface in the usual Prometheus exporters fashion.

@pedro-stanaka
Copy link
Contributor

@jsabater this seems parked for a while, feel free to put up a PR for it. Or maybe @CtrlZvi can do it some time soon.

@jsabater
Copy link

jsabater commented Jan 8, 2025

As far as I've been able to see in @CtrlZvi's repository, the code is already there so, hopefully, he could build such PR, if he has the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted PRs for this issue are especially welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@matthiasr @jsabater @pedro-stanaka @CtrlZvi @networkException