Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generator.yml #1370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update generator.yml #1370

wants to merge 1 commit into from

Conversation

manases13
Copy link

No description provided.

@manases13
Update generator.yml
2510615 
Signed-off-by: manases13 <[email protected]>
@bastischubert
Copy link
Member

@manases13 this PR uses oids that are already present in system and if_mib module. Also it's missing a proper description of the problem that is solved by this PR, the MIB file download and the changed snmp.yml

bastischubert
bastischubert requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@bastischubert bastischubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the PR Misses a description - please either fix the already mentioned issues with the PR and also please add a description what problem this PR is solving. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastischubert bastischubert bastischubert requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manases13 @bastischubert