Accept 'name' as a label #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: François-Xavier Choinière <[email protected]>
|
This makes sense! Would you mind adding a test so it doesn't break again? |
Signed-off-by: François-Xavier Choinière <[email protected]>
|
thank you! |
matthiasr
pushed a commit
that referenced
this pull request
Feb 12, 2019
Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthiasr
Fix issue #39
Since pull request #52, graphite_Exporter use the statd_exporter.
A mapping label should now be able to be named "name". There's a check in main.go that prevent it.
I've remove the unwanted line.