Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process_maximum_virtual_memory_bytes metric #438

Merged

Conversation

simonpasquier
Copy link
Member

@simonpasquier simonpasquier requested a review from grobie August 7, 2018 15:12
@beorn7 beorn7 merged commit 420e2ef into prometheus:master Aug 7, 2018
@brian-brazil
Copy link
Contributor

Any new standard exports should be added to https://prometheus.io/docs/instrumenting/writing_clientlibs/#process-metrics, as these are a standard across all client libraries in the ecosystem.

The name should also be process_virtual_memory_max_bytes per standard naming, and to be consistent with process_max_fds.

@simonpasquier simonpasquier deleted the add-max-vsize-process-metric branch August 8, 2018 06:12
@grobie
Copy link
Member

grobie commented Aug 8, 2018

The name should also be process_virtual_memory_max_bytes per standard naming

@brian-brazil I wasn't aware there are any standardized patterns around max/min/limit/etc. I'm fine with your suggestion, but couldn't find anything in that regard on https://prometheus.io/docs/practices/naming/. Is that documented anywhere else?

@brian-brazil
Copy link
Contributor

The general rule is to go from less to more specific, so related metrics have the same prefix.

@beorn7
Copy link
Member

beorn7 commented Aug 10, 2018

Thanks everybody for the hints and applying them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants