Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mesh and add it to debug logging #780

Merged
merged 3 commits into from
May 15, 2017
Merged

Update mesh and add it to debug logging #780

merged 3 commits into from
May 15, 2017

Conversation

fabxc
Copy link
Contributor

@fabxc fabxc commented May 9, 2017

A general update that's probably in order. Also mesh logs are now emitted at the debug level.

@stuartnelson3
Copy link
Contributor

Looks cool once the build passes

@fabxc
Copy link
Contributor Author

fabxc commented May 15, 2017

Ah, tests are failing because the newest mesh version uses time.Until which is new in stdlib. Travis still runs stuff against 1.7. As there's really no reason to use old Go versions, I'll remove it from Travis and 1.8+ is then a requirement for building Alertmanager.

@fabxc fabxc merged commit ff346c1 into master May 15, 2017
@fabxc fabxc deleted the meshup branch May 15, 2017 07:47
hh pushed a commit to ii/alertmanager that referenced this pull request Jan 8, 2018
@mischief @SuperQ
multiply page size after float64 coercion to avoid signed integer ove…
0629a08 
…rflow (prometheus#780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabxc @stuartnelson3