Set cache control headers in V2 API to mirror V1 #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Weaver <[email protected]>
alexweav
commented
Dec 28, 2022
alexweav
changed the title
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
|
Thank you very much for your contribution. |
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
* Set cache control headers Signed-off-by: Alex Weaver <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* Set cache control headers Signed-off-by: Alex Weaver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The V1 API sends CORS headers + the
Cache-Controlheader, all the time:alertmanager/api/v1/api.go
Line 44 in 87ad843
In V2, we replaced this with rs/cors. But, the
Cache-Controlheader is not actually a CORS-related header, so that library does not manage it. This means theCache-Controlheaders are missing in V2.This PR adds the header in the V2 API, matching V1.
Fixes #3175
Signed-off-by: Alex Weaver [email protected]