Allow selectable matchers on silence view #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartnelson3
suggested changes
Oct 6, 2017
ui/app/src/Utils/Views.elm
Outdated
| @@ -22,7 +22,9 @@ labelButton maybeMsg labelText = | |||
| case maybeMsg of | |||
| Nothing -> | |||
| span | |||
| [ class "btn btn-sm bg-faded btn-secondary mr-2 mb-2" ] | |||
| [ style [ ( "user-select", "text" ) ] | |||
There was a problem hiding this comment.
This works in chrome, but not firefox. Check out https://github.com/prometheus/alertmanager/blob/master/ui/app/src/Views/AlertList/AlertView.elm#L98-L102.
josedonizetti
force-pushed
the
allow-select-matchers-silence-view
branch
from
ce66f5f to
2ab4ed6
Compare
stuartnelson3
approved these changes
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a label is not used as a button, it allows the text to be copied. #1027