Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix golangci-lint Files Exists errors #6221

Merged
merged 4 commits into from
Jan 12, 2024
Merged

chore: fix golangci-lint Files Exists errors #6221

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
849a91b
fix golangci-lint files exists errors
dongjiang1989 Jan 11, 2024
ae6828d
sync golang verison
dongjiang1989 Jan 11, 2024
cf5bab1
Update .github/workflows/checks.yaml
dongjiang1989 Jan 12, 2024
b1956ba
Update .github/workflows/checks.yaml
dongjiang1989 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ jobs:
uses: golangci/[email protected]
with:
version: v1.55.2
args: --timeout 10m0s
args: --timeout=10m0s --go=${{ env.golang-version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed? If possible it should another PR to have a cleaner change history.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I will add another PR

skip-pkg-cache: true

check-metrics:
runs-on: ubuntu-latest
Expand Down